[PUP-4343] Add test(s) for the File resource links attribute Created: 2015/03/31  Updated: 2019/04/04  Resolved: 2015/05/20

Status: Closed
Project: Puppet
Component/s: None
Affects Version/s: None
Fix Version/s: PUP 4.1.0

Type: Improvement Priority: Normal
Reporter: Kurt Wall Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to PUP-4079 investigate File Type high-priority t... Resolved
Template:
Story Points: 1
Sprint: Client 2015-04-15, Client 2015-04-29
QA Contact: Kurt Wall

 Description   

The links attribute of the File resource type is only lightly tested in either spec or acceptance. Fix this.



 Comments   
Comment by Kurt Wall [ 2015/03/31 ]

Test Rail test case ID C64301

Comment by Eric Thompson [ 2015/04/15 ]

merged commit d64faca into puppetlabs:master

Comment by Kurt Wall [ 2015/04/16 ]

Broke Windows specs:. For example

  1) Puppet::Type::File copying a file that is a link to a directory when the recurse attribute is false should copy the link itself if :links => manage
     Failure/Error: expect(File).to be_symlink(copy)
       expected `File.symlink?("C:/Windows/Temp/rspecrun20150415-1156-7lafti/copy20150415-1156-1h4iwin")` to return true, got false
     # ./spec/integration/type/file_spec.rb:1617:in `block (4 levels) in <top (required)>'
     # ./spec/integration/type/file_spec.rb:76:in `block (3 levels) in <top (required)>'
     # ./lib/puppet/context.rb:64:in `override'
     # ./lib/puppet.rb:223:in `override'
     # ./spec/integration/type/file_spec.rb:75:in `block (2 levels) in <top (required)>'

PR-3827 should fix it.

Comment by Eric Thompson [ 2015/04/16 ]

did the second PR clear CI?

Comment by Kurt Wall [ 2015/04/16 ]

Finally, yes![1]

[1] This comment formatted with wasavi.

Generated at Thu Nov 14 10:54:13 PST 2019 using JIRA 7.7.1#77002-sha1:e75ca93d5574d9409c0630b81c894d9065296414.