[PUP-6650] hiera_include doesn't work when using environment catalogs and environment caching Created: 2016/08/24 Updated: 2016/09/07 Resolved: 2016/09/02
|Affects Version/s:||PUP 4.6.1|
|Fix Version/s:||PUP 4.6.2|
|Remaining Estimate:||Not Specified|
|Time Spent:||Not Specified|
|Original Estimate:||Not Specified|
That the override of hiera_include in the environment compiler works also when an environment is cached, and when the environment has been in use for regular compilations before an environment compilation.
|Release Notes:||Bug Fix|
|Release Notes Summary:|| Puppet 4.6.1 introduced a regression in the fix of
• Environment catalog requests will fail if hiera_include is already present in the loader
For subsequent environment catalog requests, hiera_include has already either been loaded (if the previous request was for an agent catalog using hiera_include) in the loader or has been pre-loaded as a stub. Our attempt to explicitly define it causes a hard error, because it's a redefinition. This happens whether hiera_include is being used or not; multiple environment catalog requests will always fail if environment caching is enabled.
• hiera_include is non-functional during agent catalog requests following an environment catalog request
If the first request for a given process is for an environment catalog, a noop version of hiera_include is created. It will then persist through the lifetime of the environment cache, causing hiera_include in agent catalogs to do nothing. This happens with puppet job run, for instance.
The breaking change was introduced in 4.6.1 in commit 95ff24739ce85c3b7ca5ca1bffee9247c0cc2c5e.
|Comment by Nick Lewis [ 2016/08/24 ]|
|Comment by Henrik Lindberg [ 2016/08/24 ]|
Hm, maybe we should support a loader instance that at an appropriate place in the hierarchy where the patched functions can be added. This loader would be cleared on each compilation.
|Comment by Thomas Hallgren [ 2016/08/25 ]|
|Comment by Henrik Lindberg [ 2016/08/25 ]|
merged to stable at: 5464013
|Comment by Kenn Hussey [ 2016/09/02 ]|
John Duarte can this be resolved now that the release has shipped?
|Comment by John Duarte [ 2016/09/02 ]|
Shipped in puppet 4.6.2.