[PUP-6876] Puppet::Settings::IniFile doesn't handle Unicode keys / sections properly - can cause `config set` / `config print` failures Created: 2016/11/03  Updated: 2016/11/22  Resolved: 2016/11/15

Status: Closed
Project: Puppet
Component/s: None
Affects Version/s: PUP 4.8.0
Fix Version/s: PUP 4.8.1

Type: Bug Priority: Normal
Reporter: Ethan Brown Assignee: Glenn Sarti
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks PUP-6188 Document Puppet::FileSystem.open / ex... Closed
Relates
relates to PUP-6875 [Spike] Investigate usage of ReGex \w... Ready for Engineering
relates to PUP-6188 Document Puppet::FileSystem.open / ex... Closed
Template:
Acceptance Criteria:

Tests prove that INI files can parse properly with UTF-8

Epic Link: Phase 1 Puppet Unicode Adoption Blockers
Team: Agent
Story Points: 2
Sprint: AP 2016-11-16

 Description   

While working on PUP-6188, it was discovered that puppet config set and puppet config print did not behave properly when using UTF-8 characters in the puppet.conf INI file.

This was traced back to a problem in Puppet::Settings::IniFile and it's ability to properly parse key / value pairs. In particular, RegEx \w character class doesn't work for Unicode, but [[:word:]] does - see more details in PUP-6875

Note that there might be 2 separate INI file parsers inside Puppet itself, and another in the INI module that might be worth investigating here.



 Comments   
Comment by Ethan Brown [ 2016/11/03 ]

Brought into sprint as this was discovered while testing PUP-6188 and is required as part of that work, but really a separate effort.

Comment by Glenn Sarti [ 2016/11/07 ]

Merged into stable at;
https://github.com/puppetlabs/puppet/commit/538125debeb0215eaafc70d44b942b1dbc2f0fd8

Will wait for green CI before merging up to master.

Comment by Glenn Sarti [ 2016/11/08 ]

Merged into master at;
https://github.com/puppetlabs/puppet/commit/8a355b73875aa58acd8a95717e80c31fb0df0795

Comment by Glenn Sarti [ 2016/11/09 ]

Passed CI in master at;
https://jenkins.puppetlabs.com/view/puppet-agent/view/master/view/puppet/job/platform_puppet_pkg-van-promote_master/368/

Comment by Kenn Hussey [ 2016/11/15 ]

Glenn Sarti please fill out the release notes field(s) for this issue.

Comment by Glenn Sarti [ 2016/11/15 ]

Ethan Brown You able to help me out with Rel Notes

Comment by Jorie Tappa [ 2016/11/21 ]

Glenn Sarti this still needs release notes, thanks

Generated at Tue Sep 29 23:32:58 PDT 2020 using Jira 8.5.2#805002-sha1:a66f9354b9e12ac788984e5d84669c903a370049.