[PUP-7134] Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding for SSL files Created: 2017/01/26  Updated: 2017/04/06  Resolved: 2017/03/22

Status: Closed
Project: Puppet
Component/s: None
Affects Version/s: PUP 4.8.0
Fix Version/s: PUP 4.10.0

Type: Improvement Priority: Normal
Reporter: Ethan Brown Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: i18n, utf-8
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
clones PUP-6925 Convert Ruby ::File calls for open to... Closed
relates to PUP-6188 Document Puppet::FileSystem.open / ex... Closed
relates to PUP-6986 Service provider fails when hasstatus... Closed
Acceptance Criteria:
  • All tests pass in places where encoding needed to change.
  • New tests demonstrate behavior is correct.
  • New acceptance tests may be needed.
Epic Link: Phase 1 Puppet Unicode Adoption Blockers
Team: Agent
Story Points: 2
Release Notes: Not Needed
QA Risk Assessment: No Action
QA Risk Assessment Reason: [Bulk update] Testing, infrastructure, research tickets do not require risk assessment


This is an extension of work from PUP-6925. That ticket originally also covered SSL files, but due to time constraints those efforts have been moved to this ticket.

The original PUP-6925 ticket description follows:

There are still a smattering of calls to File.open or similar in the Puppet code that should use Puppet::FileSystem and that should explicitly specify an encoding.

Make sure UTF-8 is used where possible, but be careful to leave some calls as the default Encoding.default_external in the case they are operating system managed files or expect different encodings.

This is an extension of work started in PUP-6188 which was about how to use FileSystem.open or FileSystem.exclusive_open with an encoding.

Comment by Moses Mendoza [ 2017/02/17 ]

merged to master at https://github.com/puppetlabs/puppet/commit/b440c9c0909065ae7d33c4aaeaa00fe57817ee2f

Comment by Josh Cooper [ 2017/03/22 ]

This passed CI awhile ago, and we don't need any docs/release notes, resolving.

Generated at Tue Aug 11 00:28:16 PDT 2020 using Jira 8.5.2#805002-sha1:a66f9354b9e12ac788984e5d84669c903a370049.