[PUP-7304] Perform type validation on individual entries as they are looked up, not the full hash Created: 2017/03/05  Updated: 2017/03/10  Resolved: 2017/03/07

Status: Closed
Project: Puppet
Component/s: None
Affects Version/s: PUP 4.9.3
Fix Version/s: PUP 4.9.4

Type: Improvement Priority: Normal
Reporter: Thomas Hallgren Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: flanders-ss
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Epic Link: Productize 'lookup'
Team: Puppet Developer Experience
Story Points: 1
Sprint: PDE 2017-03-08
Release Notes: Not Needed
Release Notes Summary: small performance improvement - there are others as well that will get a release note.
QA Risk Assessment: No Action
QA Risk Assessment Reason: performance related internal change


Hiera 5 performs a type validation on the hash that is delivered by a data_hash function. This can lead to degraded performance since that hash might potentially be very big (see example in PUP-7294). A better approach would be to skip that validation and instead validate each value when it is being looked up.

Comment by John Duarte [ 2017/03/06 ]

https://github.com/puppetlabs/puppet/pull/5690 merged into puppet#stable at https://github.com/puppetlabs/puppet/commit/26285c43990f0f7730b00af936ee29cd979aad20 awaiting validation in CI

Generated at Thu Feb 27 00:52:45 PST 2020 using JIRA 7.7.1#77002-sha1:e75ca93d5574d9409c0630b81c894d9065296414.