[PUP-8126] puppet module install --module_repository broken in 5.3.3 Created: 2017/11/07  Updated: 2017/11/07  Resolved: 2017/11/07

Status: Closed
Project: Puppet
Component/s: None
Affects Version/s: PUP 5.3.3
Fix Version/s: None

Type: Bug Priority: Normal
Reporter: Christoph Maser Assignee: Unassigned
Resolution: Incomplete Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to PUP-8008 puppet module install fails to instal... Closed
Template:
Method Found: Needs Assessment
QA Risk Assessment: Needs Assessment

 Description   

After an upgrade to 5.3.3 puppet module install --module_repository does not work anymore as documented at https://puppet.com/docs/puppet/5.3/modules_installing.html#installing-from-another-module-repository

puppet --version
5.3.2
 
puppet module install --module_repository http://myforge.local.lan/ puppetlabs/stdlib
WARN: Clearing out unresolved specs.
Please report a bug if this causes problems.
Notice: Preparing to install into /home/cmaser/.puppetlabs/etc/code/modules ...
Notice: Downloading from http://myforge.local.lan/ ...
Notice: Installing -- do not interrupt ...
/home/cmaser/.puppetlabs/etc/code/modules
└── puppetlabs-stdlib (v4.21.0)

$ puppet --version
5.3.3
 
$ puppet module install --module_repository http://myforge.local.lan/ puppetlabs/stdlib
Notice: Preparing to install into /home/cmaser/.puppetlabs/etc/code/modules ...
Notice: Created target directory /home/cmaser/.puppetlabs/etc/code/modules
Notice: Downloading from http://pocu-forge.server.lan/ ...
Error: undefined method `gsub' for false:FalseClass
Error: Try 'puppet help module install' for usage



 Comments   
Comment by Christoph Maser [ 2017/11/07 ]

The issue is the used in-house forge software. It returns false for response['pagination']['next']

Comment by Michael Smith [ 2017/11/07 ]

Running with --trace would help debugging what code handles this poorly. Mind running that and adding it to the ticket?

Comment by Josh Cooper [ 2017/11/07 ]

ping Jesse Scott, Ethan Brown I think this is related to https://github.com/puppetlabs/puppet/commit/77606f9ccf828976871a72a61df3066b826aa210

Comment by Christoph Maser [ 2017/11/07 ]

Hm actually i thought i closed this one. As i said the issue is response['pagination']['next'] returns flase on our in-house puppet-forge changing it to return nil resolves the problem.
This https://github.com/puppetlabs/puppet/blob/master/lib/puppet/forge.rb#L231 together with https://github.com/puppetlabs/puppet/blob/master/lib/puppet/forge.rb#L110 is the cause

Comment by Josh Cooper [ 2017/11/07 ]

Thanks Christoph Maser. Based on your comment, I'm going to close this. Please reopen if I misunderstood.

Generated at Sat Jan 25 00:21:42 PST 2020 using JIRA 7.7.1#77002-sha1:e75ca93d5574d9409c0630b81c894d9065296414.