[PUP-8215] Tag filtering for skip_tag incorrectly expanded Created: 2017/11/29  Updated: 2019/06/12  Resolved: 2019/06/04

Status: Resolved
Project: Puppet
Component/s: Catalog Application
Affects Version/s: PUP 5.3.3
Fix Version/s: PUP 6.5.0

Type: Bug Priority: Normal
Reporter: Kevin Henner Assignee: Jacob Helwig
Resolution: Fixed Votes: 0
Labels: resolved-issue-added
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relates to PUP-4495 Puppet 3.5.0 introduced a regression ... Closed
Template: PUP Bug Template
Epic Link: Tag You're It
Team: Coremunity
Sprint: Platform Core KANBAN
Method Found: Needs Assessment
Release Notes: Bug Fix
Release Notes Summary: Tags specified via --skip_tags are no longer expanded by splitting on "::". This brings the behavior in line with how tags specified via --tags are handled. The behavior of --tags was fixed in PUP-4495.
QA Risk Assessment: Needs Assessment


--skip_tags foo::bar splits the tag on the namespace separator :: and expands to skip the set ['foo::bar', 'foo', 'bar']. Because resources are tagged with all parent tags, this means that every resource in the `foo` namespace is skipped when --skip_tags foo::bar is used. The same expansion issue was addressed for the --tags flag in PUP-4495, but it appears that the expansion logic for --tags and --skip_tags is separate.

Comment by Jakub PieĊ„kowski [ 2019/05/03 ]

I opened pull request fixing this problem: https://github.com/puppetlabs/puppet/pull/7508

Comment by Jacob Helwig [ 2019/05/13 ]

This was merged into the master branch in c86ad5546d.

Comment by Josh Cooper [ 2019/06/04 ]

Passed CI in 5c982fea6fd94e1abe8895a1ba28b4ae4134249a

Generated at Tue Aug 11 00:52:52 PDT 2020 using Jira 8.5.2#805002-sha1:a66f9354b9e12ac788984e5d84669c903a370049.