[PUP-8898] Change default input_method for Task object type Created: 2018/05/29  Updated: 2018/09/19  Resolved: 2018/06/07

Status: Closed
Project: Puppet
Component/s: None
Affects Version/s: None
Fix Version/s: PUP 6.0.0

Type: Improvement Priority: Normal
Reporter: Cas Donoghue Assignee: Cas Donoghue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks BOLT-536 Default input method of PowerShell fi... Resolved
Template:
Team: Bolt
Sprint: Bolt Kanban
Release Notes: New Feature
Release Notes Summary: The input_method property of Tasks now defaults to undef rather than the string "both". This allows more flexibility in defaults and what input_methods we choose to support in the future.
QA Risk Assessment: Needs Assessment

 Description   

When a Task is run using BOLT puppet code is used to parse the task metadata. If `input_method` is not defined the default is set to `both`. https://github.com/puppetlabs/puppet/blob/a5385a74bdf7eb754dafed1f557563d97eb68bcd/lib/puppet/pops/pcore.rb#L74 

In the case where Bolt is used to run a task the default `input_method` should be set based on the combination of programming language the task is implemented in and the transport. For example if a powershell task is run over winrm the default `input_method` should be `powershell`.

Proposed change: Puppet sets default value for `input_method` to `nil` when `input_method` is not defined. The responsibility for setting appropriate `input_method` for running tasks in Bolt will be handled in the various transport implementations. 

Relates to BOLT-536

https://tickets.puppetlabs.com/browse/BOLT-536

 

 

 

 

 



 Comments   
Comment by Jacob Helwig [ 2018/05/30 ]

Merged to master branch in puppet in 5f919012f2.

Generated at Wed Jul 17 12:09:58 PDT 2019 using JIRA 7.7.1#77002-sha1:e75ca93d5574d9409c0630b81c894d9065296414.