[PUP-9092] External process termination handling rate (including "exec" resource) is slow Created: 2018/08/30 Updated: 2019/04/04 Resolved: 2018/10/08
|Affects Version/s:||PUP 4.10.5|
|Fix Version/s:||PUP 5.5.7, PUP 6.0.2|
|Reporter:||Aristarkh Zagorodnikov||Assignee:||Josh Cooper|
|Remaining Estimate:||Not Specified|
|Time Spent:||Not Specified|
|Original Estimate:||Not Specified|
|Template:||PUP Bug Template customfield_10700 273491|
|Sprint:||Platform Core KANBAN|
|Method Found:||Needs Assessment|
|Release Notes:||Bug Fix|
|Release Notes Summary:||Previously puppet took at least one second to execute external processes, even if the process completed more quickly than that. This fix significantly decreases the time it takes the puppet agent to apply a catalog if the catalog contains a large number of exec resources and each child process completes in less than 1 second.|
|QA Risk Assessment:||Needs Assessment|
Puppet Version: 4.10.5+
Executing external processes by puppet on Windows can be very slow, compared to the execution time of the process itself, if the execution time is below 1 second. When applying manifests that contain many "exec" resources, it may take many minutes to apply. When analyzing logs, I took note that even simple "reg query" process took 1.02/1.03 second to run. Windows doesn't spawn processes that slow, I wrote simple example in C# which showed that my machine is capable of executing about 140 of such commands per second (no parallelism, waiting for exit of each process before spawning another).
I did a little more digging and found out that this 'sleep(1)' was added to properly handle signals, I did additional testing ("exec"-ed a slow process and tried to Ctrl-C an interactive puppet run), and it worked.
Desired Behavior: Process termination is handled immediately
Actual Behavior: Processes are considered to be running at least for 1 second, even if they exit immediately
It would be great if this gets into 4.10.z release train, since at least our company is not yet ready for 5.x.
|Comment by Josh Cooper [ 2018/10/02 ]|
|Comment by Josh Cooper [ 2018/10/08 ]|
passed CI for 5.5.x and 6.0.x