[PUP-9130] tagging with undef should not add a tag Created: 2018/09/11  Updated: 2018/09/19  Resolved: 2018/09/17

Status: Closed
Project: Puppet
Component/s: None
Affects Version/s: None
Fix Version/s: PUP 6.0.0

Type: Bug Priority: Normal
Reporter: Henrik Lindberg Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template: PUP Bug Template
Acceptance Criteria:

It should not tag anything when giving a tag as undef.

Team: Platform Core
Method Found: Needs Assessment
Release Notes: Not Needed
Release Notes Summary: No need to release-note since bug never released (PUP-9112 is for Puppet 6.0.0).
QA Risk Assessment: Needs Assessment


In PUP-9112 we stopped translating puppet's undef to Ruby symbol :undef in the resource API. As a consequence, if trying to tag with an undef value this ended up as an empty string (nil.to_s is an empty string). This was then correctly flagged as an error.

The change in PUP-9112 thus revealed a long standing bug, where tagging with undef actually tagged the resource with the string "undef", which is completely useless since it cannot be used or queried using undef.

Any undef/nil values should simply be dropped in the tagging process.

Comment by Scott Garman [ 2018/09/17 ]

Since we had a green run of CI puppet-agent 6.0.0 last night, I'm bulk-changing these issues from Ready for CI -> Resolved in preparation of the release.

Generated at Wed Nov 20 21:50:16 PST 2019 using JIRA 7.7.1#77002-sha1:e75ca93d5574d9409c0630b81c894d9065296414.