[PUP-9134] FromDataHash should not crash if hash with __ptype key is not a type Created: 2018/09/12 Updated: 2018/09/19 Resolved: 2018/09/17
|Fix Version/s:||PUP 6.0.0|
|Remaining Estimate:||Not Specified|
|Time Spent:||Not Specified|
|Original Estimate:||Not Specified|
|Template:||PUP Bug Template customfield_10700 275447|
|Method Found:||Needs Assessment|
|Release Notes:||Not Needed|
|Release Notes Summary:||Very special case caused by non user facing logic|
|QA Risk Assessment:||Needs Assessment|
In case FromDataHash is given a hash where a key is "__ptype", and its value is not a type, it should then assume that what it is looking at is just a hash instead of crashing.
This is caused by the ToStringifiedConverter not converting to a safe form when seeing such a hash. The ToStringifyConverter should simply generate "reserved-key: __ptype" for such hashes since the result is for human consumption.
|Comment by Scott Garman [ 2018/09/17 ]|
Since we had a green run of CI puppet-agent 6.0.0 last night, I'm bulk-changing these issues from Ready for CI -> Resolved in preparation of the release.