[PUP-9134] FromDataHash should not crash if hash with __ptype key is not a type Created: 2018/09/12  Updated: 2018/09/19  Resolved: 2018/09/17

Status: Closed
Project: Puppet
Component/s: None
Affects Version/s: None
Fix Version/s: PUP 6.0.0

Type: Bug Priority: Normal
Reporter: Henrik Lindberg Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template: PUP Bug Template
Team: Platform Core
Method Found: Needs Assessment
Release Notes: Not Needed
Release Notes Summary: Very special case caused by non user facing logic
QA Risk Assessment: Needs Assessment


In case FromDataHash is given a hash where a key is "__ptype", and its value is not a type, it should then assume that what it is looking at is just a hash instead of crashing.

This is caused by the ToStringifiedConverter not converting to a safe form when seeing such a hash. The ToStringifyConverter should simply generate "reserved-key: __ptype" for such hashes since the result is for human consumption.

Comment by Scott Garman [ 2018/09/17 ]

Since we had a green run of CI puppet-agent 6.0.0 last night, I'm bulk-changing these issues from Ready for CI -> Resolved in preparation of the release.

Generated at Sun Oct 20 20:03:24 PDT 2019 using JIRA 7.7.1#77002-sha1:e75ca93d5574d9409c0630b81c894d9065296414.