[PUP-920] Add catalog application information to report Created: 2013/12/03  Updated: 2018/04/09  Resolved: 2018/03/14

Status: Closed
Project: Puppet
Component/s: None
Affects Version/s: None
Fix Version/s: PUP 5.5.0

Type: Improvement Priority: Normal
Reporter: Kylo Ginsberg Assignee: Melissa Stone
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to PUP-6344 metrics.time.total does not correlate... Closed
relates to PUP-8511 Total time reported in report probabl... Closed
Template:
Epic Link: Agent Run Report Improvements
Sub-team: Coremunity
Team: Platform Core
Story Points: 3
Sprint: Platform Core KANBAN
Release Notes: New Feature
Release Notes Summary: Time metrics recorded in the run report now include the time it takes to convert the catalog, plugin sync, generate facts, retrieve nodes, and evaluate transactions.
QA Contact: Erik Dasher
QA Risk Assessment: No Action

 Description   

As in PUP-919, this should add an agent "phase" to the report for catalog application.

This should include errors during application, such as dependency cycles detected. This should include a fix for http://projects.puppetlabs.com/issues/14458.



 Comments   
Comment by Jacob Helwig [ 2018/02/08 ]

We should add individual timing information for how long it took to do:

  • Pluginsync
  • Fact generation
  • Transaction evaluation (transaction.evaluate in catalog.rb)
  • Agent-side catalog conversion (convert_catalog in configurer.rb)
  • Node retrieval

There's a previous PR that attempted to tackle some of these: https://github.com/puppetlabs/puppet/pull/4042

Comment by Josh Cooper [ 2018/03/13 ]

Merged to 5.5.x in https://github.com/puppetlabs/puppet/commit/7611f1b3f150460df5487f1fbf3b13d6df8a0f44

Comment by Josh Cooper [ 2018/03/13 ]

Melissa Stone could you add release notes?

Comment by Melissa Stone [ 2018/03/14 ]

This has passed CI with puppet-agent 5.4.0.507.gf67d266

Generated at Wed Nov 13 11:46:22 PST 2019 using JIRA 7.7.1#77002-sha1:e75ca93d5574d9409c0630b81c894d9065296414.