[SERVER-1743] Separate check-for-updates call into new TK service Created: 2017/03/03  Updated: 2017/06/28  Resolved: 2017/06/28

Status: Closed
Project: Puppet Server
Component/s: None
Affects Version/s: None
Fix Version/s: SERVER 5.0.0

Type: Improvement Priority: Normal
Reporter: Jeremy Barlow Assignee: Jeremy Barlow
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Epic Link: Add Server metrics to OSS
Team: Systems Engineering
Sub-team: Server
Story Points: 2
Release Notes: Not Needed
QA Risk Assessment: Needs Assessment

 Description   

As we complete the work to migrate the puppetserver metrics implementation from PE into OSS, I'd like to be able to have the master-service in OSS puppetserver be used directly in PE puppetserver, avoiding the duplication of logic that occurs between the master and pe-master services today - CA initialization, Puppet HTTP route registrations, etc.

One major difference between the OSS and PE master services today is that the OSS master service does a check-for-updates call to dujour whereas in PE, the dujour work is done from a separate "analytics" trapperkeeper service. For this ticket, I'd like to mirror that approach in OSS puppetserver - moving the check-for-updates call into an OSS-specific "analytics" trapperkeeper service. We'd only bootstrap the appropriate service for the target puppetserver package - OSS vs. PE.

Patrick Carlisle and Brian Cain have been discussing moving the analytics service in pe-puppet-server-extensions into its own repo at some point. Maybe it would make sense to move an OSS-based analytics service out to a new repo as well at some point. In the short term, though, I think at least separating the OSS check-for-updates work into a new TK service would allow for the OSS master service to be reusable in PE - with the possibility of the OSS analytics service potentially being moved to somewhere else later on.



 Comments   
Comment by Jeremy Barlow [ 2017/03/03 ]

Patrick Carlisle, Brian Cain - any concerns if the "Puppet Server" team takes this on for Puppet Server 5?

Comment by Patrick Carlisle [ 2017/03/03 ]

No, seems fine.

Comment by Jeremy Barlow [ 2017/03/14 ]

Merged to puppetserver#master at 17e18a. Tests still passing so marking resolved.

Comment by Kenn Hussey [ 2017/05/15 ]

Jeremy Barlow please provide release notes for this issue, if applicable.

Generated at Thu Nov 21 03:08:44 PST 2019 using JIRA 7.7.1#77002-sha1:e75ca93d5574d9409c0630b81c894d9065296414.