[SERVER-499] Fix pre_suite for Windows Created: 2015/03/19  Updated: 2016/09/27  Resolved: 2015/03/26

Status: Closed
Project: Puppet Server
Component/s: Puppet Server
Affects Version/s: None
Fix Version/s: SERVER 2.0.0

Type: Bug Priority: Normal
Reporter: Jeff McCune Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: AIO, updated_release_notes
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to SERVER-519 Review 2.0.0 Debian Family Changes Closed
relates to SERVER-420 Try out puppet-server acceptance agai... Closed
relates to SERVER-510 Get windows2008r2-64a layouts passing... Closed
Template:
Epic Link: Green: Puppet 4.0 Changes
Sub-team: emerald
Story Points: 2
Sprint: Server Emerald 2015-04-01
QA Contact: Erik Dasher

 Description   

Windows agents are failing acceptance tests in the pre_suite phase because repositories are trying to be configured.

We simply need to skip this step for windows agents.

#<RuntimeError: No repository installation step for windows yet...>
/usr/local/rvm/gems/ruby-1.9.3-p484/bundler/gems/beaker-7d0cccf22cc7/lib/beaker/dsl/install_utils.rb:1117
/var/lib/jenkins/workspace/experimental_puppet-server_integration-system_smoke-aio/LAYOUT/redhat7-64m-windows2008r2-64a/LDAP_TYPE/PLATFORM/NONE/label/beaker/acceptance/suites/pre_suite/foss/10_install_release_repos.rb:3
/var/lib/jenkins/workspace/experimental_puppet-server_integration-system_smoke-aio/LAYOUT/redhat7-64m-windows2008r2-64a/LDAP_TYPE/PLATFORM/NONE/label/beaker/acceptance/suites/pre_suite/foss/10_install_release_repos.rb:2
/var/lib/jenkins/workspace/experimental_puppet-server_integration-system_smoke-aio/LAYOUT/redhat7-64m-windows2008r2-64a/LDAP_TYPE/PLATFORM/NONE/label/beaker/acceptance/suites/pre_suite/foss/10_install_release_repos.rb:2
/usr/local/rvm/gems/ruby-1.9.3-p484/bundler/gems/beaker-7d0cccf22cc7/lib/beaker/dsl/structure.rb:41
/var/lib/jenkins/workspace/experimental_puppet-server_integration-system_smoke-aio/LAYOUT/redhat7-64m-windows2008r2-64a/LDAP_TYPE/PLATFORM/NONE/label/beaker/acceptance/suites/pre_suite/foss/10_install_release_repos.rb:1
/usr/local/rvm/gems/ruby-1.9.3-p484/bundler/gems/beaker-7d0cccf22cc7/lib/beaker/test_case.rb:120
/usr/local/rvm/gems/ruby-1.9.3-p484/bundler/gems/beaker-7d0cccf22cc7/lib/beaker/test_case.rb:120
/usr/local/rvm/rubies/ruby-1.9.3-p484/lib/ruby/1.9.1/benchmark.rb:295
/usr/local/rvm/gems/ruby-1.9.3-p484/bundler/gems/beaker-7d0cccf22cc7/lib/beaker/test_case.rb:117
/usr/local/rvm/gems/ruby-1.9.3-p484/bundler/gems/beaker-7d0cccf22cc7/lib/beaker/test_suite.rb:286
/usr/local/rvm/gems/ruby-1.9.3-p484/bundler/gems/beaker-7d0cccf22cc7/lib/beaker/test_suite.rb:283
/usr/local/rvm/gems/ruby-1.9.3-p484/bundler/gems/beaker-7d0cccf22cc7/lib/beaker/test_suite.rb:283
/usr/local/rvm/gems/ruby-1.9.3-p484/bundler/gems/beaker-7d0cccf22cc7/lib/beaker/test_suite.rb:325
/usr/local/rvm/gems/ruby-1.9.3-p484/bundler/gems/beaker-7d0cccf22cc7/lib/beaker/cli.rb:147
/usr/local/rvm/gems/ruby-1.9.3-p484/bundler/gems/beaker-7d0cccf22cc7/lib/beaker/cli.rb:89
/usr/local/rvm/gems/ruby-1.9.3-p484/bundler/gems/beaker-7d0cccf22cc7/bin/beaker:6
/usr/local/rvm/gems/ruby-1.9.3-p484/bin/beaker:23
/usr/local/rvm/gems/ruby-1.9.3-p484/bin/beaker:23
/usr/local/rvm/gems/ruby-1.9.3-p484/bin/ruby_executable_hooks:15
/usr/local/rvm/gems/ruby-1.9.3-p484/bin/ruby_executable_hooks:15
Warning: acceptance/suites/pre_suite/foss/10_install_release_repos.rb errored in 0.37 seconds

Reproducible with smoke test job parameters LAYOUT_AXIS=redhat7-64m-windows2008r2-64a, PACKAGE_BUILD_VERSION=2.0.0.SNAPSHOT.2015.03.19T1436 and PUPPET_BUILD_VERSION=7e8ad0146f4240779cd50d307f5964c0380f16cd.



 Comments   
Comment by Jeff McCune [ 2015/03/19 ]

Left off porting over install_puppet_from_msi from Puppet to Puppet Server. The beaker version is totally borked on needlessly trying to compare versions.

Comment by Jeff McCune [ 2015/03/20 ]

I think this is 1 point planned for in SERVER-412.

Comment by Jeff McCune [ 2015/03/22 ]

Pre-suite for windows is passing fully now in the puppet-server (aio) 20: Smoke Acceptance Test Suite.

We're getting two errored tests in the full acceptance suite when running the redhat7-64m-windows2008r2-64a layout, but both of these errors are related to a known foregapi SSL issue.

The foregeapi SSL issue that is already reported in PUP-3442 with a robust solution described in PUP-3445.

Comment by Jeff McCune [ 2015/03/25 ]

Pull Request 2 at https://github.com/puppetlabs/puppet-server/pull/473 The first PR didn't fix the pre-suite because I screwed up the logic while addressing review comments.

Comment by Jeff McCune [ 2015/03/26 ]

Made it through the master branch pipeline last night.

Generated at Sat Feb 22 05:24:19 PST 2020 using JIRA 7.7.1#77002-sha1:e75ca93d5574d9409c0630b81c894d9065296414.