[TK-443] clj-http-client: Add setting to turn off url metrics Created: 2017/05/31 Updated: 2017/06/14 Resolved: 2017/06/14 |
|
Status: | Resolved |
Project: | Trapperkeeper |
Component/s: | None |
Affects Version/s: | None |
Fix Version/s: | None |
Type: | Task | Priority: | Normal |
Reporter: | Ruth Linehan | Assignee: | Justin Stoller |
Resolution: | Fixed | Votes: | 0 |
Labels: | None | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original Estimate: | Not Specified |
Issue Links: |
|
||||||||||||||||
Template: | customfield_10700 193834 | ||||||||||||||||
Epic Link: | Http client metrics | ||||||||||||||||
Team: | Systems Engineering | ||||||||||||||||
Sub-team: | Server | ||||||||||||||||
Story Points: | 3 | ||||||||||||||||
Sprint: | Server 2017-06-14, Server 2017-06-28 | ||||||||||||||||
Release Notes: | Not Needed | ||||||||||||||||
QA Risk Assessment: | Needs Assessment |
Description |
Currently, clj-http-client automatically creates a metric for every url and for every url + method. While this may be helpful in some use cases, at least for Puppet Server we have metric-ids for all the metrics we care about, so these url/url and method metrics are unneeded. We should add a setting that can be set when creating an http client that determines whether to create url metrics or not - something like `enable-url-metrics?` - and then we can set this to false in puppet server to turn these metrics off. This shouldn't need to be a user-configurable setting (for puppet server users). |
Comments |
Comment by Justin Stoller [ 2017/06/14 ] |
This has been merged into clj-http-client and released in version 0.9.0 of that library. We're in the process of promoting that through clj-parent and up-taking into puppetserver. When we bring it into puppetserver we need to set up puppetserver to take advantage of the ability to disable the metrics. That work is ticketed in |